server: Convert monitor_cb from prepare handle to raft_step callback
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a prepare handle is unreliable, since while the process is paused by a Jepsen nemesis there might be a lot of data being received by the kernel in the TCP buffer, and that data will be read eagerly by libuv, so the prepare handle callback will not get a chance to run and detect the leadership lost in a timely manner. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 60.46% 60.30% -0.17%
==========================================
Files 33 33
Lines 6137 6134 -3
Branches 1850 1850
==========================================
- Hits 3711 3699 -12
- Misses 1235 1243 +8
- Partials 1191 1192 +1
☔ View full report in Codecov by Sentry. |
This mitigates test flakiness on slower hardware, since operations will fail after a longer timeout. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
freeekanayaka
force-pushed
the
fix-monitor-cb
branch
from
347d482
to
08eec58
Compare
Only run tests using gcc on latest Ubuntu. Signed-off-by: Free Ekanayaka <free@ekanayaka.io>
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a prepare handle is unreliable, since while the process is paused by a Jepsen nemesis there might be a lot of data being received by the kernel in the TCP buffer, and that data will be read eagerly by libuv, so the prepare handle callback will not get a chance to run and detect the leadership lost in a timely manner.