Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RawTextLineReader doesn't skip line feeds correctly on Windows #6

Closed
ndikan opened this issue Jul 24, 2013 · 1 comment
Closed

RawTextLineReader doesn't skip line feeds correctly on Windows #6

ndikan opened this issue Jul 24, 2013 · 1 comment

Comments

@ndikan
Copy link
Contributor

ndikan commented Jul 24, 2013

in com.fasterxml.sort.std.RawTextLineReader#readNext, the start index is stored before the call to _skipCR(), so that even if _skipCR() skips the LF byte by incrementing ++_inputPtr following the CR, the Arrays.copyOfRange call below still has it.

On windows, this results in sorted files being written with:
<LF>
data...data...data<CRLF>
<LF>
data...data...data<CRLF>
@ndikan ndikan mentioned this issue Jul 24, 2013
Merged
@ndikan
Copy link
Contributor Author

ndikan commented Jul 24, 2013

Fixed in #7

@ndikan ndikan closed this as completed Jul 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndikan