Windows CRLF bug fix, renamed _skipCR to _skipLF to reflect the byte the... #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the method is skipping, not the byte that indicates it needs to be called.
|
Very good catch & excellent point wrt bad name. Should have added unit tests for this originally; I develop on unix so I didn't observe the issue, but should definitely test for it. |
cowtowncoder
added a commit
that referenced
this pull request
Jul 24, 2013
Windows CRLF bug fix, renamed _skipCR to _skipLF to reflect the byte the...
|
Great! And thanks for the excellent library! |
|
You are welcome. And once again thank you for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... method is skipping, not the byte that indicates it needs to be called.
This is a proposed fix for Issue 6