Skip to content

Sorter#_merge() not closing streams correctly.  #8

@tjoneslo

Description

@tjoneslo

In the method Sorter#_merge(), the list of data readers is never closed. Which means the finally block where the input files are deleted, the files won't be deleted until the GC finally notices the open files are no longer used, then closes them and deletes the files.

I'm using the merge-sort as part of a much large, long running process which means the files may be left open, and on disk, for a significant period of time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions