Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy CoyIM install on Mac #178

Closed
1 of 2 tasks
tdruiva opened this issue Dec 15, 2015 · 17 comments
Closed
1 of 2 tasks

Easy CoyIM install on Mac #178

tdruiva opened this issue Dec 15, 2015 · 17 comments

Comments

@tdruiva
Copy link
Contributor

tdruiva commented Dec 15, 2015

  • Brew formula
  • Brew cask

Or one of them?

@tdruiva tdruiva added the task label Dec 15, 2015
@tcz001 tcz001 changed the title Easy CoyIM install Easy CoyIM install on Fedora and Mac Dec 15, 2015
@sriprasanna
Copy link

I just raised a pull request to add CoyIM installer here.

I would like add an AUR package for CoyIM, should I create a separate issue or is it possible to add that to the platforms list above?

@vitorgalvao
Copy link

Just to stop any confusion, @sriprasanna’s contribution is not a homebrew formula, but rather a homebrew-cask cask (different projects).

The main difference is that in homebrew-cask we’re just getting the ready-made package you provide, while homebrew can compile from source. If what you want is the latter rather then the former, then the submissions has to go about a different way. In the past we had no problem in having the same package across projects, but since we’re in talks of merging under the same organisation, we want to stop that duplication.

@sriprasanna
Copy link

@tdruiva With the context provided by @vitorgalvao let me if you prefer homebrew formula over the cask.

@tcz001 tcz001 changed the title Easy CoyIM install on Fedora and Mac Easy CoyIM install on Mac Jan 4, 2016
@tcz001
Copy link
Contributor

tcz001 commented Jan 4, 2016

I've split this issue, for fedora it's here #197

@sriprasanna
Copy link

@tcz001 So are we going ahead with the cask?

@tcz001
Copy link
Contributor

tcz001 commented Jan 4, 2016

I think for now we can accept cask since we already have a binary built by travis-ci & bintray. And for people who want to try build from source, we provide documentation for dev.

@juniorz
Copy link
Member

juniorz commented Jan 4, 2016

cask does not require the user to compile (and download/compile all the dependencies) but relies on somebody else (us?) to always provide compiled versions (.dmg), and the user must trust this version does not have any backdoor.

What benefit it provides over downloading the .dmg? Automation? Who are the target users for this?

I'm ok with having a brew cask, but it's one more piece of software that needs to be manually maintained on every version released. It can't be automated since it depends on a 3rd party to accept a PR to some brewcask repo.

@tcz001
Copy link
Contributor

tcz001 commented Jan 4, 2016

brew formula is actually having similar problem, we need to make sure the build process is not having backdoor and also need to provide more instructions about dependencies.

We already have dmg and binaries released on bintray, this has been a highly trusted place we do distribution officially.

@sriprasanna
Copy link

@juniorz I understand your concern.

You are right, homebrew-cask doesn't require user to download and compile the source code. Instead, it downloads binaries from trusted source(Bintray in this case). You can find complete information on the official page.

Homebrew-cask is just an extension on top of homebrew(just another tap) which lets you install binaries with ease.

Maintenance:

It doesn't matter if we go with homebrew or homebrew-cask we still have to modify the installation formula.

Automating this with homebrew-cask in the pipeline is pretty easy:
  1. Push to Bintray
  2. Update version and sha256
  3. Push to Github
  4. Raise pull request

The steps for homebrew-cask remains the same even if you add a new dependency to the application(ex: go, gtk+3, etc,.).
But it will not be the same for homebrew formula. You will have to manually modify your homebrew formula to include the new dependencies.

Target users

I personally use homebrew to install all system packages(ex: git, postgres, ack, etc,. ) and use homebrew-cask for all desktop applications(ex: Firefox, Virtualbox, LibreOffice, etc,.). For example: You cannot install Firefox through homebrew directly but you can install by tapping homebrew-cask. So far homebrew-cask has 2938 casks available.

Pull requests

Both homebrew and homebrew-cask communities work in a similar fashion. If you want the formula in the main repository you will have to raise a pull request.

Hope that helps.

@vitorgalvao
Copy link

@juniorz Regarding your concerns, @sriprasanna made a good job of explaining how homebrew-cask works (and how it compares to homebrew), but there are some points I’d like to add:

  • We do not accept any cask in our main repo that does not have a download source that every user can verify by going to the application’s website. Only official verifiable sources are allowed.
  • We’re pretty fast accepting PRs. Many times just a few minutes, and most of the time in the same day (if it’s just a version bump, you can be pretty sure that’ll be the case).
  • You don’t have to depend on a third party. You can just as well keep the file in your own repo (which you have write access to) and direct users to install from there via brew cask install <url>.

@adidalal
Copy link

adidalal commented Jan 5, 2016

Now available with brew cask install coyim (brew update if you don't see it, of course)

@sriprasanna
Copy link

Thanks @vitorgalvao @adityadalal924

@tcz001
Copy link
Contributor

tcz001 commented Jan 5, 2016

Thanks for updates :)

@sriprasanna
Copy link

@tcz001 Are you going to close this issue?

@vitorgalvao
Copy link

Just noticed the updated first post.

To reiterate, we’re currently trying to get rid of duplicates, and this is something both teams agree is a good thing.

So it’s either (in the official repos) a cask or a formula, but not both.

@tcz001
Copy link
Contributor

tcz001 commented Jan 5, 2016

Closing

@sriprasanna
Copy link

@tcz001 Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants