Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for the Addition of 4K Support Option #1

Closed
x-legion opened this issue Jan 6, 2023 · 4 comments
Closed

Request for the Addition of 4K Support Option #1

x-legion opened this issue Jan 6, 2023 · 4 comments

Comments

@x-legion
Copy link

x-legion commented Jan 6, 2023

We propose the inclusion of an option that allows for 4K support within the extension. When selected, this option would search for and replace occurrences of 2048 with 4096 in the ui-config.json file, followed by a restart of the UI or reload config somehow. If the option is subsequently deselected, the original configurations would be restored. Implementing this feature would greatly enhance the user experience

@Coyote-A
Copy link
Owner

Coyote-A commented Jan 6, 2023

I think the better solution is to add custom width and height sliders in script ui. We will implement this soon

@Coyote-A
Copy link
Owner

Coyote-A commented Jan 6, 2023

Implemented this in b3d1698

@Coyote-A Coyote-A closed this as completed Jan 6, 2023
@x-legion
Copy link
Author

x-legion commented Jan 6, 2023

Nice. It's even better now. Any plan to add batches for the grid? like multiple batches could help utilizing full performance. now its limited to one at a time.

@Coyote-A
Copy link
Owner

Coyote-A commented Jan 6, 2023

Thanks for the suggestion! we have to research it. This sounds complicated, because our upscaler does not work with a grid of independent tiles, but through many inpaints of a large picture. This is necessary for better convergence of tiles. I'm afraid that when using batches, there will be visible image overlays at the seams. For now, I can advise you to increase the tile size, this should reduce the performance overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants