Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl datetime dropdown #74

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

samsoft00
Copy link
Contributor

@samsoft00 samsoft00 commented May 21, 2023

Screenshot 2023-05-21 at 11 35 24 AM

@vercel
Copy link

vercel bot commented May 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monorepo-main-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 9:10am
monorepo-website ❌ Failed (Inspect) May 22, 2023 9:10am

"date-fns": "^2.29.3"
"date-fns": "^2.29.3",
"dayjs": "~1.11.7",
"moment": "^2.29.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sam, do we really need all three date packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, remove date-fn and moment

{ key: "DD/MM/YY", value: "DD/MM/YY (22/01/06)" },
{ key: "X", value: "X (1137971045)" }
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that we are making a drop down. But is this too complicated? Check what Airtable does . 5 or 6 simple options, with a live example so you can see what it looks like.

Also, the current date in cozemble does not support time. My thinking so far was to model time as its own type....but not sure if that is a good idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this, I'm willing to make adjustments.


<label class="label" for="date-format-selector">Date format selector</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're getting better with svelte :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 😄

</div>
<!--
<label class="label" for="date-format-input">Date format:</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this commented out code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants