-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl datetime dropdown #74
base: main
Are you sure you want to change the base?
Conversation
samsoft00
commented
May 21, 2023
•
edited
Loading
edited
![Screenshot 2023-05-21 at 11 35 24 AM](https://private-user-images.githubusercontent.com/5300891/239735161-5631b395-5761-48ea-85de-48ca4166c178.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI0NTQ1MTQsIm5iZiI6MTcyMjQ1NDIxNCwicGF0aCI6Ii81MzAwODkxLzIzOTczNTE2MS01NjMxYjM5NS01NzYxLTQ4ZWEtODVkZS00OGNhNDE2NmMxNzgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDczMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MzFUMTkzMDE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzRkNmYyM2E3NmIwNWM0NTI5ZDllYTljNGVmMGY0NmY1YTVmODIwNjdhMjAwZmQ5NThiZDNiNWRjNzJmNmE2NiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.H8hY-H52uinH3ec-SPFLiVHfwHdFd87a_gZLhx9UmEc)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
model/date/core/package.json
Outdated
"date-fns": "^2.29.3" | ||
"date-fns": "^2.29.3", | ||
"dayjs": "~1.11.7", | ||
"moment": "^2.29.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sam, do we really need all three date packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, remove date-fn
and moment
{ key: "DD/MM/YY", value: "DD/MM/YY (22/01/06)" }, | ||
{ key: "X", value: "X (1137971045)" } | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that we are making a drop down. But is this too complicated? Check what Airtable does . 5 or 6 simple options, with a live example so you can see what it looks like.
Also, the current date in cozemble does not support time. My thinking so far was to model time as its own type....but not sure if that is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss this, I'm willing to make adjustments.
|
||
<label class="label" for="date-format-selector">Date format selector</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're getting better with svelte :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 😄
</div> | ||
<!-- | ||
<label class="label" for="date-format-input">Date format:</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this commented out code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll handle that.
3e76d9d
to
3bf2206
Compare