Fix "onlyInvert" inversionAttempts option #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`shouldInvert` should also be true if `options.inversionAttempts` equals "onlyInvert".
|
Definitely recommend squashing last three commits on merge! Was mostly playing around with the tslint config in this project. |
ccinelli
pushed a commit
to ccinelli/jsQR
that referenced
this pull request
Dec 30, 2019
danimoh
added a commit
to danimoh/jsQR
that referenced
this pull request
Jul 9, 2020
Squashed commit of the following: commit e7f282a Author: LakeGH <lake@peardeck.com> Date: Thu Nov 14 13:29:15 2019 -0500 Removing unneeded whitespace. commit 13843e5 Author: LakeGH <lake@peardeck.com> Date: Thu Nov 14 13:14:50 2019 -0500 Remove trailing whitespace for tslint commit 4f3fef8 Author: LakeGH <lake@peardeck.com> Date: Thu Nov 14 13:12:12 2019 -0500 Change order of inversionAttempts check for tslint commit 0dfc578 Author: LakeGH <lake@peardeck.com> Date: Thu Nov 14 12:55:55 2019 -0500 Fix "onlyInvert" inversionAttempts option. `shouldInvert` should also be true if `options.inversionAttempts` equals "onlyInvert".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118.
shouldInvertshould also be true ifoptions.inversionAttemptsequals "onlyInvert".