Include milliseconds in Windows Stat dates #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
changed the title
@gyselroth/windows-fsstat to v1.0.0
This version returns access and modification dates with milliseconds instead of truncating them to the second.
Atom Watcher steps were passed the client sync path directly by the watcher. However, we'll want to access other attributes of the configuration in some steps so we'll pass the full Config instead and use its syncPath attribute when necessary.
Stat dates on Windows were previously truncated to the second while we now get the milliseconds as well. To avoid re-calculating all the local checksums during the initial scan because of the date migration, we'll truncate `scan` events dates to the second during the first initial scan following the publication of v3.28.1 when checking if the checksum of a given file can be reused or not. When publishing v3.28.2 or greater, we can remove `WINDOWS_DATE_MIGRATION_FLAG` and stop truncating dates during the initial scan. Users who will have skipped the version introducing the flag will see all their checksums re-computed.
taratatach
force-pushed
the
windows/include-milliseconds-in-stat-dates
branch
from
3cf1e7b
to
d9c069f
Compare
nono
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, we use a third-party library (i.e.
@gyselroth/windows-fsstat) to compute file and directory statsbecause the non-BigInt version of
fs.statwould not always return aunique
inodevalue (i.e. the returnedinodevalue of 2 files ordirectories could be the same).
However, this library would truncate all dates to the second and this
can lead us to discard very close modifications since we now expect
the modification date to be different to process a local event as a
modification.
We've modified our fork of
@gyselroth/windows-fsstatto includemilliseconds in returned dates and use it in the client.
Since changing the modification date of most files would trigger a lot
of checksums re-computing, we include a "migration" to prevent this
during the first initial scan.
Please make sure the following boxes are checked: