feat: Add WEB_OAUTH flag to build the web version but with OAuth Auth #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to be able to embed our web build in an other native app and load it locally.
ptbrowne
reviewed
Apr 7, 2020
| }) | ||
| ] | ||
|
|
||
| if (WEB_OAUTH) { |
There was a problem hiding this comment.
I am not sure that WEB_OAUTH is the right term here since we have a reference to the cozy-bar below, which is not linked to "oauth". Could we find a better term here ? Should we have another target instead of webpack.target.browser ?
There was a problem hiding this comment.
I didn't want to create too much noise around the webpack config since you're migrating it to cozy-scripts. I don't know if I really want that PR to be merged right now.
But yeah you're right, I think the goal is to:
- keep the OAUTH__AUTH flag to know if we want an OAuth auth or not and remove the check for TARGET === mobile
- add an
embeddedtarget - add an
embeddedconfig
The result will be:
- target mobile will use the
webpack.config.embeddedto inject cozy-bar, cozy-client-js but keep other plugins like providing pouchDB stuff - target embedded will only use
webpack.config.embeddedI think - Remove the check of target === mobile to use OAUTH_AUTH when needed.
WDYT about that?
ptbrowne
force-pushed
the
master
branch
3 times, most recently
from
bf49acb
to
47f8e48
Compare
|
I'm closing this PR since there is no need anymore to use this kind of hack. We use an override to do what we have to do, and we only serve the web version for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to be able to embed our web build in an other native app
and load it locally.
run: env WEB_OAUTH=true yarn build:browser