Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndexName should use partialIndex/Filter #1054

Closed
Crash-- opened this issue Oct 25, 2021 · 0 comments · Fixed by #1191
Closed

IndexName should use partialIndex/Filter #1054

Crash-- opened this issue Oct 25, 2021 · 0 comments · Fixed by #1191
Labels
bug Something isn't working

Comments

@Crash--
Copy link
Contributor

Crash-- commented Oct 25, 2021

Currently the indexName is based on the sort() fields or indexedFileds.

But if we add a partial selector in the request, we'll use the same index. We need to include the partialFilter in the index name.

(see https://mattermost.cozycloud.cc/cozycloud/pl/6jk58iifziftmfq166shbogprw for more informations)
@Crash-- Crash-- added the bug Something isn't working label Oct 25, 2021
@paultranvan paultranvan mentioned this issue Dec 17, 2021
Closed
@paultranvan paultranvan mentioned this issue Jun 6, 2022
Merged
paultranvan added a commit that referenced this issue Jun 23, 2022
@paultranvan
feat: Add the partial filter fields in the index name
8a3b819 
When using a partial index, its fields weren't part of the index name.
Therefore, we might have a conflict situation where there is already an
existing index without the partial index.
Fix #1054
paultranvan added a commit that referenced this issue Jun 23, 2022
@paultranvan
feat: Add the partial filter fields in the index name
d93a889 
When using a partial index, its fields weren't part of the index name.
Therefore, we might have a conflict situation where there is already an
existing index without the partial index.
Fix #1054
paultranvan added a commit that referenced this issue Jun 23, 2022
@paultranvan
feat: Add the partial filter fields in the index name
928af96 
When using a partial index, its fields weren't part of the index name.
Therefore, we might have a conflict situation where there is already an
existing index without the partial index.
Fix #1054
@paultranvan paultranvan mentioned this issue Jun 23, 2022
Merged
paultranvan added a commit that referenced this issue Jun 24, 2022
@paultranvan
feat: Add the partial filter fields in the index name
99ccad3 
When using a partial index, its fields weren't part of the index name.
Therefore, we might have a conflict situation where there is already an
existing index without the partial index.
Fix #1054
paultranvan added a commit that referenced this issue Jun 24, 2022
@paultranvan
feat: Add the partial filter fields in the index name
32c432d 
When using a partial index, its fields weren't part of the index name.
Therefore, we might have a conflict situation where there is already an
existing index without the partial index.
Fix #1054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add the partial filter fields in the index name cozy/cozy-client
1 participant
@Crash--