Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Creation group with Safari #967

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: Creation group with Safari #967

merged 1 commit into from
Apr 3, 2024

Conversation

Merkur39
Copy link
Member

@Merkur39 Merkur39 commented Apr 3, 2024

### 🐛 Bug Fixes

* On Safari, the SelectBox menu for group creation from a contact's info modal passes below the content of the modal.
  The change in approach to handling menu closure when clicked outside the menu means we can remove the `z-index` forced on the `react-select` container that was causing the problem.

On Safari, the SelectBox menu for group creation
from a contact's info modal passes below the content of the modal.

The change in approach to handling menu closure when
clicked outside the menu means we can remove the
`z-index` forced on the `react-select` container that
was causing the problem.
@Merkur39 Merkur39 requested a review from zatteo April 3, 2024 09:46
@Merkur39 Merkur39 requested a review from JF-Cozy as a code owner April 3, 2024 09:46
Copy link

bundlemon bot commented Apr 3, 2024

BundleMon

Files updated (2)
Status Path Size Limits
app/contacts.(hash).js
281.95KB (-13B 0%) -
vendors/contacts.(hash).js
684.59KB (-3.51KB -0.51%) -
Unchanged files (4)
Status Path Size Limits
services/keepIndexFullNameAndDisplayNameUpToD
ate/contacts.js
311.01KB -
intents/contacts.(hash).js
27.36KB -
app-contacts.(hash).min.css
27.15KB -
img/icon.(hash).svg
454B -

Total files change -3.53KB -0.26%

Groups updated (1)
Status Path Size Limits
**/*.js
1.27MB (-3.53KB -0.27%) -
Unchanged groups (2)
Status Path Size Limits
**/*.css
85.02KB -
img/.
454B -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Merkur39 Merkur39 merged commit 5f55f07 into master Apr 3, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the feat/ver-439 branch April 3, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants