Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use client.destroy from new cozy-client #968

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Apr 3, 2024

### 🔧 Tech

* Update cozy-client
* Use client.destroy from new cozy-client 

Copy link

bundlemon bot commented Apr 3, 2024

BundleMon

Files updated (2)
Status Path Size Limits
intents/contacts.(hash).js
27.52KB (-41B -0.15%) -
app/contacts.(hash).js
282.1KB (-46B -0.02%) -
Unchanged files (4)
Status Path Size Limits
vendors/contacts.(hash).js
692.79KB -
services/keepIndexFullNameAndDisplayNameUpToD
ate/contacts.js
289.73KB -
app-contacts.(hash).min.css
26.95KB -
img/icon.(hash).svg
454B -

Total files change -87B -0.01%

Groups updated (1)
Status Path Size Limits
**/*.js
1.26MB (-87B -0.01%) -
Unchanged groups (2)
Status Path Size Limits
**/*.css
84.55KB -
img/.
454B -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

@JF-Cozy JF-Cozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qu'est-ce que ça fait d'utiliser client.destroy de la nouvelle version ? On corrige un bug ? Je suppose que c'est en lien avec cozy/cozy-client#1458 mais on pourrait l'indiquer dans la description pour expliquer que c'est pour mutualiser avec l'Extension

@zatteo zatteo force-pushed the feat/use-cozy-client-destroy branch from bea9656 to af7c0fc Compare April 4, 2024 07:59
@zatteo
Copy link
Contributor Author

zatteo commented Apr 4, 2024

Qu'est-ce que ça fait d'utiliser client.destroy de la nouvelle version ? On corrige un bug ? Je suppose que c'est en lien avec cozy/cozy-client#1458 mais on pourrait l'indiquer dans la description pour expliquer que c'est pour mutualiser avec l'Extension

Tout à fait c'est simplement de l'homogénéisation. J'ai précisé le message de commit.

Logic to destroy a contact has been centralized on cozy-client
collection. We just homogeneize the code here.
@zatteo zatteo force-pushed the feat/use-cozy-client-destroy branch from af7c0fc to a6abb1a Compare April 10, 2024 12:39
@zatteo zatteo merged commit 3869c98 into master Apr 12, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the feat/use-cozy-client-destroy branch April 12, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants