Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalName, surname and region fields #970

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Apr 9, 2024

### ✨ Features

* Add additionalName, surname and region fields
* Change list order for address

@JF-Cozy JF-Cozy requested a review from Merkur39 as a code owner April 9, 2024 08:20
Copy link

bundlemon bot commented Apr 9, 2024

BundleMon

Files updated (2)
Status Path Size Limits
intents/contacts.(hash).js
27.56KB (+209B +0.75%) -
app/contacts.(hash).js
282.15KB (+196B +0.07%) -
Unchanged files (4)
Status Path Size Limits
vendors/contacts.(hash).js
692.79KB -
services/keepIndexFullNameAndDisplayNameUpToD
ate/contacts.js
289.73KB -
app-contacts.(hash).min.css
26.95KB -
img/icon.(hash).svg
454B -

Total files change +405B +0.03%

Groups updated (1)
Status Path Size Limits
**/*.js
1.26MB (+405B +0.03%) -
Unchanged groups (2)
Status Path Size Limits
**/*.css
84.55KB -
img/.
454B -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Comment on lines +93 to +94
additionalName: additionalName,
surname: surname,
Copy link
Member

@Merkur39 Merkur39 Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Ne devrait-on pas suivre la logique existante, soit || '' ? Histoire que les attributs de name soient du même type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est vrai que ça pose question, mais si on fait ça, ça build le displayName et le fullName avec un espace en trop. Et après coup, je me suis dit que c'était stupide de mettre des chaines vides plutôt que des undefined... ou alors y'a un truc qui m’échappe 🤔

src/locales/de.json Show resolved Hide resolved
src/locales/es.json Show resolved Hide resolved
src/locales/nl_NL.json Show resolved Hide resolved
Comment on lines +44 to +45
"additionalName": "2e prénom",
"surname": "Nom d'usage",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Je pense qu'à l'avenir nous pouvons nous contenter de la traduction anglaise/française.
(si besoin de plus, la comu proposera) 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je crois qu'on supporte aussi l'ES officiellement. Mais ok pour les autres, faudrait que je me remette à jour sur ce qu'on en fait justement...

@JF-Cozy JF-Cozy merged commit f711b1d into master Apr 9, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the feat/VER-86-1 branch April 9, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants