-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additionalName, surname and region fields #970
Conversation
JF-Cozy
commented
Apr 9, 2024
•
edited
edited
BundleMonFiles updated (2)
Unchanged files (4)
Total files change +405B +0.03% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
additionalName: additionalName, | ||
surname: surname, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Ne devrait-on pas suivre la logique existante, soit || ''
? Histoire que les attributs de name
soient du même type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c'est vrai que ça pose question, mais si on fait ça, ça build le displayName et le fullName avec un espace en trop. Et après coup, je me suis dit que c'était stupide de mettre des chaines vides plutôt que des undefined... ou alors y'a un truc qui m’échappe 🤔
"additionalName": "2e prénom", | ||
"surname": "Nom d'usage", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Je pense qu'à l'avenir nous pouvons nous contenter de la traduction anglaise/française.
(si besoin de plus, la comu proposera) 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je crois qu'on supporte aussi l'ES officiellement. Mais ok pour les autres, faudrait que je me remette à jour sur ce qu'on en fait justement...