Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label rework on phone/address/email/cozy input #971

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Apr 11, 2024

Anciennement on avait des libellés libres pour les champs phone/address/email/cozy dont la valeur était stockée sur un attribut type pour chaque champ.
image

Avec cette PR les libellés ne sont plus des champs libres. On introduit un nouvel attribut label en plus de l'attribut type. (PR sur les cozy doctypes à venir). L'attribut type peut avoir les valeurs null|voice|fax|cell|custom (selon le type de champ) et l'attribut label les valeurs home|work.

Graphiquement on passe d'un champ libre à un select :
image

La valeur "personnalisé" permet de renseigner le type voulu autre que ceux proposés.

Pour assurer la rétro-compatibilité on gère les cas s'il y a un type mais pas de label etc.

### ✨ Features

* Label rework for phone/address/email/cozy input

@JF-Cozy JF-Cozy requested a review from Merkur39 as a code owner April 11, 2024 14:26
@JF-Cozy JF-Cozy requested a review from zatteo April 11, 2024 14:27
Copy link

bundlemon bot commented Apr 11, 2024

BundleMon

Files updated (3)
Status Path Size Limits
vendors/contacts.(hash).js
694.34KB (+1.55KB +0.22%) -
app/contacts.(hash).js
283.41KB (+1.31KB +0.46%) -
intents/contacts.(hash).js
28.69KB (+1.16KB +4.23%) -
Unchanged files (3)
Status Path Size Limits
services/keepIndexFullNameAndDisplayNameUpToD
ate/contacts.js
289.73KB -
app-contacts.(hash).min.css
26.95KB -
img/icon.(hash).svg
454B -

Total files change +4.02KB +0.3%

Groups updated (1)
Status Path Size Limits
**/*.js
1.27MB (+4.02KB +0.31%) -
Unchanged groups (2)
Status Path Size Limits
**/*.css
84.55KB -
img/.
454B -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

src/components/ContactCard/ContactFieldInput.jsx Outdated Show resolved Hide resolved
src/components/ContactCard/ContactFields/helpers.js Outdated Show resolved Hide resolved
src/components/Form/CustomLabelDialog.jsx Show resolved Hide resolved
src/components/Form/helpers.js Show resolved Hide resolved
src/components/Form/helpers.js Show resolved Hide resolved
CODEOWNERS Show resolved Hide resolved
@Merkur39
Copy link
Member

Bien joué, hâte de tester le résultat ! 👏

@JF-Cozy JF-Cozy merged commit 683d929 into master Apr 15, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the feat/VER-86-2 branch April 15, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants