-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label rework on phone/address/email/cozy input #971
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should be listed in the project's dependencies. Run 'npm i -S ...' to add it
BundleMonFiles updated (3)
Unchanged files (3)
Total files change +4.02KB +0.3% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
Merkur39
reviewed
Apr 13, 2024
Bien joué, hâte de tester le résultat ! 👏 |
Merkur39
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anciennement on avait des libellés libres pour les champs phone/address/email/cozy dont la valeur était stockée sur un attribut
type
pour chaque champ.Avec cette PR les libellés ne sont plus des champs libres. On introduit un nouvel attribut
label
en plus de l'attributtype
. (PR sur les cozy doctypes à venir). L'attributtype
peut avoir les valeursnull|voice|fax|cell|custom
(selon le type de champ) et l'attributlabel
les valeurshome|work
.Graphiquement on passe d'un champ libre à un select :
La valeur "personnalisé" permet de renseigner le
type
voulu autre que ceux proposés.Pour assurer la rétro-compatibilité on gère les cas s'il y a un
type
mais pas delabel
etc.