Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoDefineLabels #979

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Add autoDefineLabels #979

merged 3 commits into from
Apr 25, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Apr 24, 2024

C'est un service qui assure que les champs address/cozy/phone/email aient bien un label s'ils ont un type

### ✨ Features

* Add autoDefineLabels service

Copy link

bundlemon bot commented Apr 24, 2024

BundleMon

Files added (1)
Status Path Size Limits
services/autoDefineLabels/contacts.js
+288.81KB -
Files updated (2)
Status Path Size Limits
app/contacts.(hash).js
283.33KB (+44B +0.02%) -
services/keepIndexFullNameAndDisplayNameUpToD
ate/contacts.js
288.75KB (-1.53KB -0.53%) -
Unchanged files (4)
Status Path Size Limits
vendors/contacts.(hash).js
696.29KB -
intents/contacts.(hash).js
28.58KB -
app-contacts.(hash).min.css
26.97KB -
img/icon.(hash).svg
454B -

Total files change +287.33KB +21.67%

Groups updated (1)
Status Path Size Limits
**/*.js
1.55MB (+287.33KB +22.13%) -
Unchanged groups (2)
Status Path Size Limits
**/*.css
84.6KB -
img/.
454B -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

updatedContactsToUpload.length &&
log,
date: normalizedService?.current_state?.last_success,
callback: contact => updateIndexFullNameAndDisplayName(contact)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas besoin de "omit" _type ici, comme la précédente implémentation ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non j'ai supprimé le commentaire car l'issue en référence a été corrigée

@JF-Cozy JF-Cozy merged commit d630b5a into master Apr 25, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the feat/VER-485-2 branch April 25, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants