Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Can now deal with [null] value for address/phone/email/cozy #981

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Apr 25, 2024

see cozy/cozy-client#1469

### ✨ Features

* Can now deal with `[null]` value for address/phone/email/cozy

Comment on lines 73 to 79
const emailValue =
email && email.length > 0
? movePrimaryToHead(email).map(item => ({
email: item.address,
email: item?.address,
emailLabel: makeItemLabel(item)
}))
: [undefined]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voila possiblement une raison du undefined 🤔

Copy link

bundlemon bot commented Apr 25, 2024

BundleMon

Files updated (5)
Status Path Size Limits
services/keepIndexFullNameAndDisplayNameUpToD
ate/contacts.js
294.15KB (+5.4KB +1.87%) -
services/autoDefineLabels/contacts.js
294.21KB (+5.4KB +1.87%) -
vendors/contacts.(hash).js
701.05KB (+4.76KB +0.68%) -
app/contacts.(hash).js
283.35KB (+17B +0.01%) -
intents/contacts.(hash).js
28.59KB (+12B +0.04%) -
Unchanged files (2)
Status Path Size Limits
app-contacts.(hash).min.css
26.97KB -
img/icon.(hash).svg
454B -

Total files change +15.6KB +0.97%

Groups updated (1)
Status Path Size Limits
**/*.js
1.56MB (+15.6KB +0.98%) -
Unchanged groups (2)
Status Path Size Limits
**/*.css
84.6KB -
img/.
454B -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@JF-Cozy JF-Cozy merged commit 2160b81 into master Apr 25, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the fix/contacts branch April 25, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants