Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add redirection for unsupported routes #986

Merged
merged 1 commit into from
May 13, 2024
Merged

feat: Add redirection for unsupported routes #986

merged 1 commit into from
May 13, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented May 13, 2024

### ✨ Features

* Add redirection for unsupported routes


Copy link

bundlemon bot commented May 13, 2024

BundleMon

Files updated (2)
Status Path Size Limits
vendors/contacts.(hash).js
701.23KB (+77B +0.01%) -
app/contacts.(hash).js
283.36KB (+19B +0.01%) -
Unchanged files (5)
Status Path Size Limits
services/autoDefineLabels/contacts.js
294.21KB -
services/keepIndexFullNameAndDisplayNameUpToD
ate/contacts.js
294.15KB -
intents/contacts.(hash).js
28.59KB -
app-contacts.(hash).min.css
26.97KB -
img/icon.(hash).svg
454B -

Total files change +96B +0.01%

Groups updated (1)
Status Path Size Limits
**/*.js
1.56MB (+96B +0.01%) -
Unchanged groups (2)
Status Path Size Limits
**/*.css
84.6KB -
img/.
454B -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Member

@Merkur39 Merkur39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Cela devrait bien marcher pour toutes les routes ayant au moins un contactId valide (ou groupId), je suppose qu'il nous faudrait un ErrorBoundary pour les autres cas

@JF-Cozy
Copy link
Contributor Author

JF-Cozy commented May 13, 2024

ça marche aussi pour les routes du style #/foo/bar

@JF-Cozy JF-Cozy merged commit 9b15ed5 into master May 13, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the feat/routes branch May 13, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants