Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve cozy-bar interactions #2608

Merged
merged 1 commit into from Jun 2, 2022
Merged

fix: Improve cozy-bar interactions #2608

merged 1 commit into from Jun 2, 2022

Conversation

acezard
Copy link
Contributor

@acezard acezard commented May 23, 2022 •
edited

WebviewIntent was not passed correctly in most cases

@bundlemon
Copy link

bundlemon bot commented May 23, 2022 •
edited

BundleMon

Files updated (3)
Status Path Size Limits
✅ app/drive.(hash).js
 230.54KB (+51B +0.02%) 234KB
✅ public/drive.(hash).js
 1.52MB (-222B -0.01%) 1.6MB
✅ vendors/drive.(hash).js
 1.46MB (-285B -0.02%) 1.54MB
Unchanged files (7)
Status Path Size Limits
✅ services/dacc/drive.js
 244.68KB 249KB
✅ services/qualificationMigration/drive.js
 239.14KB 242KB
✅ public/pdf.worker.entry.(hash).worker.js
 220.57KB 221KB
✅ public/drive.(hash).min.css
 85.44KB 86KB
✅ app/drive.(hash).min.css
 54.51KB 55KB
✅ vendors/drive.(hash).(hash).min.css
 34.34KB 35KB
✅ public/cozy-bar.css
 18.42KB 24KB

Total files change -458B -0.01%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@acezard acezard marked this pull request as draft May 23, 2022 11:57
@acezard acezard marked this pull request as ready for review May 30, 2022 08:35
@acezard acezard force-pushed the fix/appamiraleui branch 2 times, most recently from 7225303 to 9147652 Compare May 31, 2022 07:36
@acezard acezard requested a review from JF-Cozy May 31, 2022 07:36
JF-Cozy
JF-Cozy reviewed May 31, 2022
View reviewed changes
package.json Outdated
@@ -131,7 +131,7 @@
"cozy-scripts": "6.3.1",
"cozy-sharing": "4.1.5",
"cozy-stack-client": "^29.0.0",
"cozy-ui": "^67.0.2",
"cozy-ui": "^68.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attention il y a un gros BC à gérer ici https://github.com/cozy/cozy-ui/releases/tag/v68.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JF-Cozy résultat du codemods:

Results: 
0 errors
150 unmodified
0 skipped
3 ok
Time elapsed: 147.338seconds

Est-ce ok ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je sais pas, surement :) C'est tous les fichiers qui importent le Viewer de cozy-ui, y'en a peut-être que 3 impactés effectivement (a commiter dans un commit séparé ;) )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concernés mais pas modifiés

Copy link
Contributor

@JF-Cozy JF-Cozy Jun 1, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ok" dans les "results" ça veut dire modifiés, non ? Sinon c'est "unmodified"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bizarre il m'a modifié 0 fichier sur git en tout cas après cette commande

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est pas normal. As-tu le package à jour ? Fais-tu la commande comme indiqué dans le BC https://github.com/cozy/cozy-ui/releases/tag/v68.0.0 ?

Copy link
Contributor

@JF-Cozy JF-Cozy Jun 2, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je prends le sujet, on a rename un composant dans Drive, le codemode ne saura pas le voir...
ps : le codemods fonctionne chez moi et modifie bien des fichiers commitable pour info

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok c'est fait #2617 tu peux rebase depuis master ;)

@acezard acezard requested a review from JF-Cozy May 31, 2022 13:02
JF-Cozy
JF-Cozy approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@JF-Cozy JF-Cozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je valide pour te débloquer 😘 mais stp :

  • rebase à faire pour dégager le sujet cozy-ui et n'avoir que ta feature
  • changelog à mettre à jour

@acezard
fix: Improve cozy-bar interactions
33dfb8e 
WebviewIntent was not passed correctly in most cases
@acezard acezard merged commit c5ac1b2 into master Jun 2, 2022
@acezard acezard deleted the fix/appamiraleui branch June 2, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JF-Cozy JF-Cozy JF-Cozy approved these changes

@trollepierre trollepierre Awaiting requested review from trollepierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acezard @JF-Cozy