Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): remove dacc run from build, by moving it inside lib folder #2624

Merged
merged 1 commit into from Jun 22, 2022
Merged

fix(build): remove dacc run from build, by moving it inside lib folder #2624

merged 1 commit into from Jun 22, 2022

Conversation

trollepierre
Copy link
Contributor

@trollepierre trollepierre commented Jun 21, 2022 •
edited

  • Changelog updated if needed

No more dacc-run here:
Capture d’écran 2022-06-21 à 16 12 30

@bundlemon
Copy link

bundlemon bot commented Jun 21, 2022

BundleMon

Files updated (2)
Status Path Size Limits
✅ services/qualificationMigration/drive.js
 239.37KB (+239B +0.1%) 242KB
✅ services/dacc/drive.js
 244.55KB (-131B -0.05%) 249KB
Unchanged files (8)
Status Path Size Limits
✅ public/drive.(hash).js
 1.45MB 1.6MB
✅ vendors/drive.(hash).js
 1.39MB 1.54MB
✅ app/drive.(hash).js
 230.52KB 234KB
✅ public/pdf.worker.entry.(hash).worker.js
 220.57KB 221KB
✅ public/drive.(hash).min.css
 85.44KB 86KB
✅ app/drive.(hash).min.css
 54.51KB 55KB
✅ vendors/drive.(hash).(hash).min.css
 34.34KB 35KB
✅ public/cozy-bar.css
 18.42KB 24KB

Total files change +108B 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

paultranvan
paultranvan approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@paultranvan paultranvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trollepierre trollepierre merged commit bce9978 into master Jun 22, 2022
@trollepierre trollepierre deleted the remove-dacc-run-from-build branch June 22, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paultranvan paultranvan paultranvan approved these changes

@JF-Cozy JF-Cozy JF-Cozy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trollepierre @paultranvan @JF-Cozy