Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update err max file size handling (VO-637) #3135

Merged
merged 1 commit into from Apr 11, 2024

Conversation

acezard
Copy link
Contributor

@acezard acezard commented Apr 10, 2024

🐛 Bug Fixes

  • Removed an issue where uploading a file above quota would trigger max file size error wrongly

@acezard acezard requested a review from cballevre as a code owner April 10, 2024 08:01
Remove redundant code
Make the error detail match server
Make the name match server
@acezard acezard force-pushed the fix--Update-err-max-file-size-handling branch from 5eef65b to 4aeddc3 Compare April 10, 2024 08:26
Copy link

bundlemon bot commented Apr 10, 2024

BundleMon

Files updated (3)
Status Path Size Limits
vendors/drive.(hash).js
1.75MB (+504B +0.03%) 2MB
public/drive.(hash).js
1.54MB (+429B +0.03%) 1.7MB
app/drive.(hash).js
167.86KB (+40B +0.02%) 300KB
Unchanged files (15)
Status Path Size Limits
public/pdf.worker.entry.(hash).worker.js
343.61KB 345KB
services/qualificationMigration/drive.js
263.28KB 500KB
services/dacc/drive.js
244.41KB 500KB
public/cozy-client-js.js
158.97KB 160KB
intents/drive.(hash).js
104.9KB 190KB
public/drive.(hash).min.css
70.69KB 100KB
app-drive.(hash).min.css
36.52KB 56KB
intents-drive.(hash).min.css
33.87KB 40KB
onlyOffice/slide.pptx
24.82KB 25KB
onlyOffice/text.docx
5.84KB 6KB
onlyOffice/spreadsheet.xlsx
5.01KB 6KB
manifest.webapp
1.9KB 2KB
index.html
589B 1KB
intents/index.html
502B 1KB
manifest.json
184B 1KB

Total files change +970B +0.02%

Groups updated (3)
Status Path Size Limits
vendors/**
1.75MB (+504B +0.03%) -
public/**
2.11MB (+429B +0.02%) -
app/**
167.86KB (+40B +0.02%) -
Unchanged groups (4)
Status Path Size Limits
services/**
507.69KB -
intents/**
105.39KB -
onlyOffice/**
35.68KB -
img/**
3.41KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Member

@cballevre cballevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@acezard acezard merged commit b1b8fa6 into master Apr 11, 2024
3 checks passed
@acezard acezard deleted the fix--Update-err-max-file-size-handling branch April 11, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants