Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VO-749] fix: Recent view query was malformed #3181

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

paultranvan
Copy link
Contributor

After 6e1041f, the recent view was broken, because it introduced the dir_id sort before the updated_at sort, which is problematic, as the dir_id is meaningless for the user. Thus, we fix this by using a (type, updated_at) sort.

Furthermore, we now use a partial index for better performances.

### ✨ Features

*

### πŸ› Bug Fixes

* Recent view was not displaying in correct order

### πŸ”§ Tech

*

After 6e1041f, the recent view was
broken, because it introduced the `dir_id` sort before the `updated_at`
sort, which is problematic, as the `dir_id` is meaningless for the user.
Thus, we fix this by using a simple updated_at sort and rewrite the
query to use a partial index for better performances.
Copy link

bundlemon bot commented Jul 1, 2024

BundleMon

Files updated (3)
Status Path Size Limits
βœ… app/drive.(hash).js
173.57KB (-12B -0.01%) 300KB
βœ… public/drive.(hash).js
1.56MB (-12B 0%) 1.7MB
βœ… intents/drive.(hash).js
105.59KB (-14B -0.01%) 190KB
Unchanged files (15)
Status Path Size Limits
βœ… vendors/drive.(hash).js
1.78MB 2MB
βœ… public/pdf.worker.entry.(hash).worker.js
345.35KB 350KB
βœ… services/qualificationMigration/drive.js
279.42KB 500KB
βœ… services/dacc/drive.js
260.44KB 500KB
βœ… public/cozy-client-js.js
159.28KB 160KB
βœ… public/drive.(hash).min.css
69.72KB 100KB
βœ… app-drive.(hash).min.css
37.85KB 56KB
βœ… intents-drive.(hash).min.css
33.01KB 40KB
βœ… onlyOffice/slide.pptx
24.83KB 25KB
βœ… onlyOffice/text.docx
5.85KB 6KB
βœ… onlyOffice/spreadsheet.xlsx
5.02KB 6KB
βœ… manifest.webapp
1.87KB 2KB
βœ… index.html
595B 1KB
βœ… intents/index.html
506B 1KB
βœ… manifest.json
185B 1KB

Total files change -37B 0%

Groups updated (3)
Status Path Size Limits
βœ… app/**
173.57KB (-12B -0.01%) -
βœ… public/**
2.13MB (-12B 0%) -
βœ… intents/**
106.08KB (-14B -0.01%) -
Unchanged groups (4)
Status Path Size Limits
βœ… vendors/**
1.78MB -
βœ… services/**
539.86KB -
βœ… onlyOffice/**
35.7KB -
βœ… img/**
3.41KB -

Final result: βœ…

View report in BundleMon website ➑️


Current branch size history | Target branch size history

@paultranvan paultranvan changed the title fix: Recent view query was malformed [VO-749] fix: Recent view query was malformed Jul 2, 2024
@paultranvan paultranvan merged commit 441eb96 into master Jul 2, 2024
3 checks passed
@paultranvan paultranvan deleted the fix-recent-query branch July 2, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants