feat: Implement new eslint-config-cozy-app (VO-541) #2104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acezard
commented
Mar 11, 2024
| @@ -1,8 +1,9 @@ | |||
| import React, { useEffect, useState } from 'react' | |||
There was a problem hiding this comment.
those 3 removal were the only manual error fixes
acezard
commented
Mar 11, 2024
| @@ -113,5 +111,8 @@ | |||
| "hooks": { | |||
| "pre-commit": "lint-staged" | |||
| } | |||
| }, | |||
| "resolutions": { | |||
There was a problem hiding this comment.
we force eslint resolution to 8 or else cozy-scripts could force a mismatch and yarn will use eslint 5 or 7 in the CLI, making the lint fail
There was a problem hiding this comment.
We could make a PR on cozy-script to avoid this resolution
There was a problem hiding this comment.
We could make a PR on cozy-script to avoid this resolution
@cballevre that would be preferrable for sure but I'm not sure it would be very easy to update cozy-scripts to eslint 8
acezard
force-pushed
the
feat--Implement-new-eslint-config-cozy-app
branch
from
6cd1433
to
13bd5b9
Compare
cballevre
reviewed
Mar 11, 2024
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| @@ -113,5 +111,8 @@ | |||
| "hooks": { | |||
| "pre-commit": "lint-staged" | |||
| } | |||
| }, | |||
| "resolutions": { | |||
There was a problem hiding this comment.
We could make a PR on cozy-script to avoid this resolution
acezard
force-pushed
the
feat--Implement-new-eslint-config-cozy-app
branch
from
13bd5b9
to
0e050a2
Compare
acezard
force-pushed
the
feat--Implement-new-eslint-config-cozy-app
branch
from
0e050a2
to
5437fee
Compare
|
Closed because stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: