Skip to content

Commit

Permalink
feat(harvest): Add /config route on routerV4 and remove tabs
Browse files Browse the repository at this point in the history
as we do on router v6. Some duplicated code between v4 and v6 but
it's the simpliest way to do it. Since the v4 is almost deprecated (Home
should be update with v6 soon), there will be no reason to keep this
code anymore
  • Loading branch information
JF-Cozy committed Jan 17, 2023
1 parent b8fe298 commit 79c6947
Show file tree
Hide file tree
Showing 3 changed files with 202 additions and 14 deletions.
@@ -0,0 +1,40 @@
import React from 'react'
import DialogContent from '@material-ui/core/DialogContent'

import useBreakpoints from 'cozy-ui/transpiled/react/hooks/useBreakpoints'

import FlowProvider from '../../FlowProvider'
import TriggerError from '../TriggerError'

const AccountModalContentWrapper = ({
children,
trigger,
account,
konnector
}) => {
const { isMobile } = useBreakpoints()

return (
<DialogContent className={isMobile ? 'u-p-0' : 'u-pt-0'}>
<FlowProvider initialTrigger={trigger} konnector={konnector}>
{({ flow }) => (
<>
<TriggerError
flow={flow}
konnector={konnector}
account={account}
trigger={trigger}
/>
{React.Children.map(children, child =>
React.isValidElement(child)
? React.cloneElement(child, { flow, trigger, account })
: null
)}
</>
)}
</FlowProvider>
</DialogContent>
)
}

export default AccountModalContentWrapper
@@ -0,0 +1,88 @@
import React from 'react'
import PropTypes from 'prop-types'
import DialogContent from '@material-ui/core/DialogContent'

import { useQuery, isQueryLoading } from 'cozy-client'
import Spinner from 'cozy-ui/transpiled/react/Spinner'

import { buildAccountQueryById } from '../../../connections/accounts'
import { withMountPointProps } from '../../MountPointContext'
import { getMatchingTrigger } from '../helpers'
import AccountModalHeader from '../AccountModalHeader'
import Error from '../Error'

const AccountModalWithoutTabs = ({
accountsAndTriggers,
konnector,
accountId,
children
}) => {
const matchingTrigger = getMatchingTrigger(accountsAndTriggers, accountId)
const matchingAccountId = matchingTrigger ? accountId : undefined

const { definition, options } = buildAccountQueryById(matchingAccountId)
const { data: accounts, ...accountQueryResult } = useQuery(
definition,
options
)

const isLoading =
isQueryLoading(accountQueryResult) || accountQueryResult.hasMore

const isError =
!isLoading && (!matchingTrigger || !accounts || accounts?.length === 0)

const account = accounts?.[0]

return (
<>
<AccountModalHeader
konnector={konnector}
account={account}
accountsAndTriggers={accountsAndTriggers}
/>
{(isError || isLoading) && (
<DialogContent className="u-pb-2">
{isError && (
<Error
accountId={accountId}
accountsAndTriggers={accountsAndTriggers}
trigger={matchingTrigger}
lastError={accountQueryResult.lastError}
/>
)}
{isLoading && (
<Spinner className="u-flex u-flex-justify-center" size="xxlarge" />
)}
</DialogContent>
)}
{!isError &&
!isLoading &&
React.Children.map(children, child =>
React.isValidElement(child)
? React.cloneElement(child, {
trigger: matchingTrigger,
account,
konnector
})
: null
)}
</>
)
}

AccountModalWithoutTabs.propTypes = {
konnector: PropTypes.object.isRequired,
/**
* @type {{ account: 'io.cozy.accounts', trigger: 'io.cozy.triggers' }[]} - An array of objects containing an account and its associated trigger
*/
accountsAndTriggers: PropTypes.arrayOf(
PropTypes.shape({
account: PropTypes.object.isRequired,
trigger: PropTypes.object.isRequired
})
).isRequired,
accountId: PropTypes.string.isRequired
}

export default withMountPointProps(AccountModalWithoutTabs)
88 changes: 74 additions & 14 deletions packages/cozy-harvest-lib/src/components/Routes/RoutesV4.jsx
Expand Up @@ -9,11 +9,17 @@ import NewAccountModal from '../NewAccountModal'
import EditAccountModal from '../EditAccountModal'
import KonnectorSuccess from '../KonnectorSuccess'
import HarvestModalRoot from '../HarvestModalRoot'
import AccountModalWithoutTabs from '../AccountModalWithoutTabs/FovV4Router/AccountModalWithoutTabs'
import AccountModalContentWrapper from '../AccountModalWithoutTabs/FovV4Router/AccountModalContentWrapper'
import DataTab from '../KonnectorConfiguration/DataTab'
import ConfigurationTab from '../KonnectorConfiguration/ConfigurationTab'
import withAdaptiveRouter from '../hoc/withRouter'

const RoutesV4 = ({
konnectorRoot,
konnectorWithTriggers,
accountsAndTriggers,
historyAction,
onSuccess,
onDismiss
}) => {
Expand All @@ -29,20 +35,74 @@ const RoutesV4 = ({
/>
)}
/>
<Route
path={`${konnectorRoot}/accounts/:accountId`}
exact
render={({ match }) => (
<AccountModal
konnector={konnectorWithTriggers}
accountId={match.params.accountId}
accountsAndTriggers={accountsAndTriggers}
onDismiss={onDismiss}
showNewAccountButton={!konnectorWithTriggers.clientSide}
showAccountSelection={!konnectorWithTriggers.clientSide}
{flag('harvest.inappconnectors.enabled') ? (
<>
<Route
path={`${konnectorRoot}/accounts/:accountId`}
exact
render={({ match }) => (
<AccountModalWithoutTabs
konnector={konnectorWithTriggers}
accountId={match.params.accountId}
accountsAndTriggers={accountsAndTriggers}
showNewAccountButton={!konnectorWithTriggers.clientSide}
showAccountSelection={!konnectorWithTriggers.clientSide}
onDismiss={onDismiss}
>
<AccountModalContentWrapper>
<DataTab
konnectorRoot={`${konnectorRoot}/accounts/${match.params.accountId}`}
konnector={konnectorWithTriggers}
showNewAccountButton={!konnectorWithTriggers.clientSide}
onDismiss={onDismiss}
/>
</AccountModalContentWrapper>
</AccountModalWithoutTabs>
)}
/>
)}
/>
<Route
path={`${konnectorRoot}/accounts/:accountId/config`}
exact
render={({ match }) => (
<AccountModalWithoutTabs
konnector={konnectorWithTriggers}
accountId={match.params.accountId}
accountsAndTriggers={accountsAndTriggers}
showNewAccountButton={!konnectorWithTriggers.clientSide}
showAccountSelection={!konnectorWithTriggers.clientSide}
onDismiss={onDismiss}
>
<AccountModalContentWrapper>
<ConfigurationTab
konnector={konnectorWithTriggers}
showNewAccountButton={!konnectorWithTriggers.clientSide}
onAccountDeleted={onDismiss}
addAccount={() =>
historyAction(`${konnectorRoot}/new`, 'replace')
}
/>
</AccountModalContentWrapper>
</AccountModalWithoutTabs>
)}
/>
</>
) : (
<Route
path={`${konnectorRoot}/accounts/:accountId`}
exact
render={({ match }) => (
<AccountModal
konnector={konnectorWithTriggers}
accountId={match.params.accountId}
accountsAndTriggers={accountsAndTriggers}
onDismiss={onDismiss}
showNewAccountButton={!konnectorWithTriggers.clientSide}
showAccountSelection={!konnectorWithTriggers.clientSide}
/>
)}
/>
)}

<Route
path={`${konnectorRoot}/accounts/:accountId/edit`}
exact
Expand Down Expand Up @@ -91,4 +151,4 @@ const RoutesV4 = ({
)
}

export default RoutesV4
export default withAdaptiveRouter(RoutesV4)

0 comments on commit 79c6947

Please sign in to comment.