Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[realtime] Subscribe are not sent on reconnections #199

Closed
nono opened this issue Jan 2, 2019 · 1 comment
Closed

[realtime] Subscribe are not sent on reconnections #199

nono opened this issue Jan 2, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@nono
Copy link
Member

nono commented Jan 2, 2019

When the websocket closes (on a network error for example), the library tries to reconnect. If it is successful, it should also resend the subscribe from the previous calls. Currently, it just reopens the websocket and auth again. But as it does not resend subscribe, it's just a websocket that won't receive any events.
@nono nono added the bug Something isn't working label Jan 2, 2019
@gregorylegarec
Copy link
Contributor

Oh, well spotted, thanks.

@CPatchane CPatchane mentioned this issue Feb 5, 2019
Merged
CPatchane added a commit to CPatchane/cozy-libs that referenced this issue Feb 5, 2019
@CPatchane
fix: 💅 Handle correctly websocket retries
efd26d8 
Fix cozy#199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nono @gregorylegarec