fix: correctly handle settings/import link generation #47
Conversation
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using Flurl; |
There was a problem hiding this comment.
Flurl is an http client, right? Is it needed here?
There was a problem hiding this comment.
Nope, this one contains only the Url builder. Http client is served with Flurl.Http.
This is what I understand from their website : https://flurl.dev/
The native .net UrlBuilder seems not to provide any easy interface to manipulate QueryParams. I had the choice between constructing them manually or to use any known library like Flurl.
In fact for this specific import link it was not required, but I wanted to implement the same behavior than CozyClient.GenerateWebLink to be future proof.
Also I expect it to be useful when we will improve login url handling : https://trello.com/c/hJ6sa3Tn
We can still revert this choice.
There was a problem hiding this comment.
I don't want us to manipulate QueryParams / String by hands. Let's use a lib for that :)
Settings' `Import` button now correctly redirects the user by handling subdomain type (`nested` or `flat`) and by setting correct hash
Ldoppea
force-pushed
the
fix/import_vault
branch
from
f9cb62f
to
b3d84a1
Compare
Like for the extension, the mobile app was not handling subdomain type correctly. Also it was still using the old route parameters (
/installation/importvs/vault?action=import)This PR fixes those problems