Fix/resolve warnings #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
approved these changes
Nov 24, 2021
`Build.VERSION.Sdk` was deprecated in API level 15 `Build.VERSION.SdkInt`should be used instead More info: https://developer.android.com/reference/android/os/Build.VERSION#SDK_INT
This API is deprecated from API 20 Also the code that uses this API is targeting Android Lollipop and prior versions As we support only API 21 and later, this code is deadcode
Ldoppea
force-pushed
the
fix/resolve_warnings
branch
from
728739d
to
ff6a9b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to resolve some of the compilation warning that are displayed in VS.
I did not resolve all warnings related to SDK version as resolving them would break compatibility with some older devices (SDK 21 -> 26)