Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle ciphers login ellipsis #53

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Nov 26, 2021

On grouping view ciphers subtitles are truncated if too long

A supernumerary column declaration was breaking the grid and ciphers
subtitles were truncated if longer than the cipher's name, even if
there was enough place to display them completly

Now ciphers subtitles take all available space and are truncated only
if larger than the screen

This reverts part of d3d7e0b


Before:
image

After:
image

Copy link
Contributor

@Crash-- Crash-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

On `grouping` view ciphers subtitles are truncated if too long

A supernumerary column declaration was breaking the grid and ciphers
subtitles were truncated if longer than the cipher's name, even if
there was enough place to display them completly

Now ciphers subtitles take all available space and are truncated only
if larger than the screen

This reverts part of d3d7e0b
@Ldoppea Ldoppea changed the base branch from fix/move_organization to master November 26, 2021 12:29
@Ldoppea Ldoppea merged commit ab564ef into master Nov 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/ciphers_ellipsis branch November 26, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants