Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove folder list on cipher creation #63

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Dec 8, 2021

Current workflow does not allow to edit cipher's folder before its
creation

This feature is disabled on cipher's creation screen until we adapt the
workflow


Future solution would be to edit the SharePage in order to:

  • take a boolean that would be true if we open the page un "create" mode
  • only set the cipher's organizationId without calling the server when validating the choice
  • then the AddEdit page would have to call the correct share method after cipher's creation (or maybe just create it if we can encrypt it directly with the org key).

Another option would be to create a new Page for that process instead of adding complexity to SharePage.

Current workflow does not allow to edit cipher's folder before its
creation

This feature is disabled on cipher's creation screen until we adapt the
workflow
@Ldoppea Ldoppea requested a review from Crash-- as a code owner December 8, 2021 17:34
@Ldoppea Ldoppea merged commit ffa507c into master Dec 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/remove_folder_list_at_creation branch December 9, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants