Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Hourly trigger #3835

Merged
merged 1 commit into from
Mar 13, 2023
Merged

feat: Add Hourly trigger #3835

merged 1 commit into from
Mar 13, 2023

Conversation

Crash--
Copy link
Contributor

@Crash-- Crash-- commented Mar 10, 2023

In order to be able to run a trigger hourly.
It was already possible to do it from the manifest but not from the API.

Copy link
Member

@nono nono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a use case for @hourly trigger?

I think it wasn't added on purpose to avoid encouraging triggers with such frequency, IIRC.

model/job/scheduler.go Outdated Show resolved Hide resolved
In order to be able to run a trigger hourly.
It was already possible to do it from the manifest
but not from the API.
@Crash--
Copy link
Contributor Author

Crash-- commented Mar 10, 2023

We have a few hourly trigger in a few konnectors (https://github.com/search?q=org%3Akonnectors%20hourly&type=code).

The idea is to remove a lot of code on the front app (harvest / cozy-client / flagship) in order to avoid creating cron but use this randomness directly from the stack (cozy/cozy-client#1325).

But I agree, I'm not sure we should continue to have an hourly trigger. Maybe we should change the frequency on those 2 konnectors.

@nono nono merged commit 7788d8f into master Mar 13, 2023
@nono nono deleted the feat/addHourlyTrigger branch March 13, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants