-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Récupérer facilement les couleurs #188
Comments
Related : webpack-contrib/stylus-loader#163 (comment) " Like the old quoted comment, I think its best to use stylus's json function to import variables from a json file that can easily be shared with js and other systems."
|
Je vote pour le |
Au sein de |
|
De notre côté, on n'utilise pas les couleurs sous forme de variable js à ma connaissance. Ceci dit la solution 3 semble effectivement la plus pertinente. |
Ah putain, je savais même pas que Stylus traitait du json comme ça. Bref du coup, la 3 me convient très bien. |
Would it be possible to also expose all palette colors as css variable? It will avoid to do this kind of trick when we don't want to use stylus : https://github.com/cozy/cozy-store/blob/master/src/styles/palette.styl |
Voici un exemple sur cozy-bank : https://gitlab.cozycloud.cc/labs/cozy-bank/commit/d48a6a3ae09eba4926fb4599f12f36711fa8b5ca |
@CPatchane : please open another issue for this :) I will do the JSON trick and have a PR soon :) |
✨ feat: have the palette in json so that JS files can load it. fix #188
Actuellement on ajoute dans chaque projet ses propres variables JS pour les couleurs alors que l'on a un référentiel dans
palette.styl
.Nous devrions pouvoir récupérer facilement une variable :
Proposition:
The text was updated successfully, but these errors were encountered: