feat: s/validate/primary/ & s/cancel/secondary/ #78
Conversation
|
Needed for cozy/cozy-drive#172 |
| ( | ||
| <button | ||
| className={classNames('coz-btn', 'coz-btn--close', styles['coz-btn-modal-close'])} | ||
| onClick={secondaryAction} |
There was a problem hiding this comment.
Let's hope we'll never have to bind different actions to the cross and the secondary button. But I think this is good as it is.
There was a problem hiding this comment.
If we need it later... We could change it later.
| } | ||
|
|
||
| const Modal = (props) => { | ||
| props.primaryType = props.primaryType || props.validateType |
There was a problem hiding this comment.
Why not use http://babeljs.io/docs/plugins/transform-es2015-parameters/ instead ?
There was a problem hiding this comment.
I do not use destructuring here because I think:
const Modal = ({ title, description, primaryType, primaryText, primaryAction, secondaryType, secondaryText, secondaryAction, validateType, validateText, validateAction, cancelType, cancelText, cancelAction, withCross }) => { /* etc. */ }was less clean than
const Modal = (props) => { /* etc. */ }mostly when I decomposed the massive Modal component into smaller one by passing them ...props instead of the props they need explicitly. Especially with a component that declares its propTypes.
But I may be wrong.
What do you think about?
There was a problem hiding this comment.
Oh yes, missed the fat arrow. Ok for me.
| primaryType: React.PropTypes.string, | ||
| primaryText: React.PropTypes.string, | ||
| primaryAction: React.PropTypes.func, | ||
| cancelType: deprecated('cancelType') || React.PropTypes.string, |
There was a problem hiding this comment.
Why is it not React.ProTypes.string || deprecated('cancelType') ?
There was a problem hiding this comment.
I would like to evaluate deprecated() (to display the deprecated warning in the console) but do not want to change the value of the cancelType parameter.
And as you can see in the two last examples in the mdn (logical OR) page:
o8 = '' || false // returns false
o9 = false || '' // returns ""
There was a problem hiding this comment.
@enguerran : ok, deprecated is a function that first warn the developpeur that the result will be false soon, and later is really deprecated ?
There was a problem hiding this comment.
Yes, that is right. they are temporary instructions that warn the developer. As soon as others apps stop using those props, we remove these declarations (and the ones in the Modal function).
To accept retro-compatibility, I had a
console.warnfor future deprecated props.I also change two things:
withCrossas a bool to control the cross display