Bugfix 0008 dispatch on managed thread #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… native thread. * Running test in Test Explorer passed. * Debugging test in Test Explorer thorws invalid handle exception at calling `CloseHandle(exitThreadEvent)` in StateMachine.NET::ManagedDispatcher::!ManagedDispatcher(). * nunit3-console.exe failed by exception.
* Test by nunit3-console.exe passed. * Debuggin test in Test Explorer still fails.
- Move exitThreadEvent handle from managed class to native class to avoid exception when ManagedDispatcher is disposed. - Debugging test in Test Explorer passed.
Because native thread can run on AppDomain of native code.
…tateMachine. Change Context constructor of tsm_NET to accept ThreadType parameter.
- Remove Context::ThreadType enum. - Add AsyncContext class which inherits from Context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8
Basic idea is that native StateMachine runs on managed thread that belongs AppDomain of application.
Then native code can interact with managed code in the same AppDomain.
In this way, native::Callback class removed at 5cb47ea is no more used.
And workaround for nunit3-console.exe described on #8 (comment) is also no more necessary.
Constructor of AsyncContext of StateMachine.NET accepts
bool useNativeThreadparameter.If it is false(default), native StateMachine creates native thread as it's worker thread.
In this case, nunit throws
System.AugumentException.To avoid this issue, pass true as
bool useNativeThreadto dispatch native StateMachine code on native thread.