Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cosmetic error only: Shows vague error message while printing #9

Closed
KenLucke opened this issue Oct 19, 2020 · 3 comments
Closed
Labels
confirmed bug Bug reproduced and needs to be fixed solved Solved, but not yet released.
Milestone

Comments

@KenLucke
Copy link
Sponsor

Describe the bug
Cosmetic bug - error message is somewhat confusing.

Steps To Reproduce
Start a print
Open Editor tab shows this error, despite the editor working just fine before starting the print:
CR-10 v2 (Yellow) LAN  OctoPrint  - 72% 2020-10-19 16-05-18
This could confuse someone into thinking that the plugin won't work for them or that there's been some sort of massive sudden EEPROM fault, when, in fact, it works fine if they were not printing at the moment.

Tiny little thing in the larger order of things, but I thought it was worth pointing out.

Expected behavior
Should say something on the order of "Error: Either this plugin does not function with your machine (only Marlin based EEPROM machines are supported) , or the plugin is currently disabled because a print is in progress."

Logs

octoprint.log: not needed for this one.

Versions, system information
Plugin:
Version: 2.0
OctoPrint
Version: 1.4.2
Operating System running OctoPrint:
Mac OS X 10.15.7
Printer model & firmware version: n/a
Browser: n/a

Additional context, screenshots, anything else you think might be useful

@KenLucke KenLucke added the potential bug Bug reported but yet to be analysed label Oct 19, 2020
@cp2004
Copy link
Owner

cp2004 commented Oct 24, 2020

Looks like that's actually the two different error messages at the same time, they should be two different cases. Think this happens if you start a print, then load the UI later on. Will fix.

@cp2004 cp2004 added confirmed bug Bug reproduced and needs to be fixed and removed potential bug Bug reported but yet to be analysed labels Oct 24, 2020
@cp2004 cp2004 added this to the 2.1.0 milestone Oct 24, 2020
@cp2004
Copy link
Owner

cp2004 commented Nov 30, 2020

Fixed for the next release. Error messages include:
Disconnected:
image
Read-only mode:
image
Firmware not marlin:
image

And maybe more, I can't remember!

@cp2004 cp2004 added the solved Solved, but not yet released. label Nov 30, 2020
@cp2004
Copy link
Owner

cp2004 commented Dec 20, 2020

3.0.0 has been released 🎉

@cp2004 cp2004 closed this as completed Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug Bug reproduced and needs to be fixed solved Solved, but not yet released.
Projects
None yet
Development

No branches or pull requests

2 participants