Conventions: Add check for portable filenames

cp2k · Mar 6, 2020 · 0d12301 · 0d12301
1 parent 3390b8d
commit 0d12301
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/tools/conventions/analyze_src.py b/tools/conventions/analyze_src.py
@@ -17,6 +17,8 @@
     r"__INTEL_COMPILER|__cplusplus|\$\{.*\}\$|__.*__"
 )
 
+portable_filename_re = re.compile(r"^[a-zA-Z0-9._/#~=+-]*$")
+
 BANNER_F = """\
 !--------------------------------------------------------------------------------------------------!
 !   CP2K: A general program to perform molecular dynamics simulations                              !
@@ -170,6 +172,9 @@ def validate(cp2k_dir, filelist=None, excluded_dirs=DEFAULT_EXCLUDED_DIRS):
             absfn = path.join(root, fn)
             shortfn = path.relpath(absfn, cp2k_dir)
 
+            if not portable_filename_re.match(fn):
+                warnings += ["Filename %s not portable" % shortfn]
+
             if not path.exists(absfn):
                 continue  # skip broken symlinks