Add initializers in xc_derivative_types

cp2k · Jun 24, 2023 · 8e79dd0 · 8e79dd0
1 parent 8bed826
commit 8e79dd0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/src/xc/xc_derivative_set_types.F b/src/xc/xc_derivative_set_types.F
@@ -53,8 +53,8 @@ MODULE xc_derivative_set_types
 !>      in form of a linked list
 ! **************************************************************************************************
    TYPE xc_derivative_set_type
-      TYPE(pw_pool_type), POINTER, PRIVATE :: pw_pool
-      TYPE(cp_sll_xc_deriv_type), POINTER :: derivs
+      TYPE(pw_pool_type), POINTER, PRIVATE :: pw_pool => NULL()
+      TYPE(cp_sll_xc_deriv_type), POINTER :: derivs => NULL()
    END TYPE xc_derivative_set_type
 
 CONTAINS
@@ -124,7 +124,6 @@ SUBROUTINE xc_dset_create(derivative_set, pw_pool, local_bounds)
 
       NULLIFY (pw_grid)
 
-      NULLIFY (derivative_set%derivs)
       IF (PRESENT(pw_pool)) THEN
          derivative_set%pw_pool => pw_pool
          CALL pw_pool_retain(pw_pool)
@@ -137,7 +136,6 @@ SUBROUTINE xc_dset_create(derivative_set, pw_pool, local_bounds)
          CPASSERT(PRESENT(local_bounds))
          CALL pw_grid_create(pw_grid, mp_comm_self)
          pw_grid%bounds_local = local_bounds
-         NULLIFY (derivative_set%pw_pool)
          CALL pw_pool_create(derivative_set%pw_pool, pw_grid)
          CALL pw_grid_release(pw_grid)
       END IF

diff --git a/src/xc/xc_derivative_types.F b/src/xc/xc_derivative_types.F
@@ -43,7 +43,7 @@ MODULE xc_derivative_types
 !> \author fawzi
 ! **************************************************************************************************
    TYPE xc_derivative_p_type
-      TYPE(xc_derivative_type), POINTER :: deriv
+      TYPE(xc_derivative_type), POINTER :: deriv => NULL()
    END TYPE xc_derivative_p_type
 
 CONTAINS

diff --git a/tools/conventions/conventions.supp b/tools/conventions/conventions.supp
@@ -832,8 +832,6 @@ xas_tdp_types.F: Found type xas_atom_env_type without initializer https://cp2k.o
 xas_tdp_types.F: Found type xas_tdp_control_type without initializer https://cp2k.org/conv#c016
 xas_tdp_types.F: Found type xas_tdp_env_type without initializer https://cp2k.org/conv#c016
 xas_tdp_utils.F: Found type dbcsr_soc_package_type without initializer https://cp2k.org/conv#c016
-xc_derivative_set_types.F: Found type xc_derivative_set_type without initializer https://cp2k.org/conv#c016
-xc_derivative_types.F: Found type xc_derivative_p_type without initializer https://cp2k.org/conv#c016
 xc.F: Found CLOSE statement in procedure "xc_vxc_pw_create_debug" https://cp2k.org/conv#c204
 xc.F: Found CLOSE statement in procedure "xc_vxc_pw_create_test_lsd" https://cp2k.org/conv#c204
 xc.F: Found OPEN statement in procedure "xc_vxc_pw_create_debug" https://cp2k.org/conv#c203