Skip to content

Commit

Permalink
grid: Touch up validation
Browse files Browse the repository at this point in the history
  • Loading branch information
oschuett committed Dec 23, 2020
1 parent 70aa981 commit 9ecfabf
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/grid/grid_task_list.c
Original file line number Diff line number Diff line change
Expand Up @@ -303,14 +303,15 @@ void grid_integrate_task_list(

// Compare forces.
const double forces_tolerance = 1e-8; // account for higher numeric noise
double forces_max_rel_diff = 0.0;
if (forces != NULL) {
for (int iatom = 0; iatom < natoms; iatom++) {
for (int idir = 0; idir < 3; idir++) {
const double ref_value = forces_ref[iatom][idir];
const double test_value = forces[iatom][idir];
;
const double diff = fabs(test_value - ref_value);
const double rel_diff = diff / fmax(1.0, fabs(ref_value));
forces_max_rel_diff = fmax(forces_max_rel_diff, rel_diff);
if (rel_diff > forces_tolerance) {
fprintf(stderr, "Error: Validation failure in grid integrate\n");
fprintf(stderr, " forces diff: %le\n", diff);
Expand All @@ -326,13 +327,15 @@ void grid_integrate_task_list(

// Compare virial.
const double virial_tolerance = 1e-8; // account for higher numeric noise
double virial_max_rel_diff = 0.0;
if (virial != NULL) {
for (int i = 0; i < 3; i++) {
for (int j = 0; j < 3; j++) {
const double ref_value = virial_ref[i][j];
const double test_value = virial[i][j];
const double diff = fabs(test_value - ref_value);
const double rel_diff = diff / fmax(1.0, fabs(ref_value));
virial_max_rel_diff = fmax(virial_max_rel_diff, rel_diff);
if (rel_diff > virial_tolerance) {
fprintf(stderr, "Error: Validation failure in grid integrate\n");
fprintf(stderr, " virial diff: %le\n", diff);
Expand All @@ -345,7 +348,8 @@ void grid_integrate_task_list(
}
}

printf("Validated grid_integrate, max rel. diff: %le\n", hab_max_rel_diff);
printf("Validated grid_integrate, max rel. diff: %le %le %le\n",
hab_max_rel_diff, forces_max_rel_diff, virial_max_rel_diff);
grid_free_buffer(hab_blocks_ref);
}
}
Expand Down

0 comments on commit 9ecfabf

Please sign in to comment.