fix conventions and remove another implicitly defined interface call

cp2k · Nov 18, 2020 · f200b32 · f200b32
1 parent 10ea29a
commit f200b32
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 3 deletions.
diff --git a/src/semi_empirical_int_utils.F b/src/semi_empirical_int_utils.F
@@ -37,6 +37,30 @@ MODULE semi_empirical_int_utils
    PUBLIC ::   ijkl_sp, ijkl_d, rotmat, rot_2el_2c_first, store_2el_2c_diag, &
              d_ijkl_sp, d_ijkl_d
 
+   ABSTRACT INTERFACE
+! **************************************************************************************************
+!> \brief ...
+!> \param r ...
+!> \param l1_i ...
+!> \param l2_i ...
+!> \param m1_i ...
+!> \param m2_i ...
+!> \param da_i ...
+!> \param db_i ...
+!> \param add0 ...
+!> \param fact_screen ...
+!> \return ...
+! **************************************************************************************************
+      FUNCTION eval_func(r, l1_i, l2_i, m1_i, m2_i, da_i, db_i, add0, fact_screen) RESULT(charg)
+         USE kinds, ONLY: dp
+      REAL(KIND=dp), INTENT(IN)                          :: r
+      INTEGER, INTENT(IN)                                :: l1_i, l2_i, m1_i, m2_i
+      REAL(KIND=dp), INTENT(IN)                          :: da_i, db_i, add0, fact_screen
+      REAL(KIND=dp)                                      :: charg
+
+      END FUNCTION eval_func
+   END INTERFACE
+
 CONTAINS
 
 ! **************************************************************************************************
@@ -201,7 +225,9 @@ FUNCTION ijkl_sp_low(sepi, sepj, ij, kl, li, lj, lk, ll, ic, r, se_int_screen, &
       INTEGER, INTENT(IN)                                :: iscreen
       LOGICAL, INTENT(IN)                                :: shortrange, pc_coulomb_int
       INTEGER, INTENT(IN)                                :: max_multipole, itype
-      REAL(KIND=dp)                                      :: eval, res
+
+      PROCEDURE(eval_func)                               :: eval
+      REAL(KIND=dp)                                      :: res
 
       INTEGER                                            :: ccc, l1, l1max, l1min, l2, l2max, l2min, &
                                                             lij, lkl, lmin, m

diff --git a/tools/conventions/conventions.supp b/tools/conventions/conventions.supp
@@ -159,6 +159,7 @@ mp2.F: Found lossy conversion real_4_r8 without KIND argument in "compute_vec_si
 pao_param_exp.F: Found lossy conversion real_4_r8 without KIND argument in "zheevd_wrapper"
 parallel_rng_types_unittest.F: Found WRITE statement with hardcoded unit in "dump_reload_check"
 parallel_rng_types_unittest.F: Found WRITE statement with hardcoded unit in "parallel_rng_types_test"
+parallel_rng_types_unittest.F: Found WRITE statement with hardcoded unit in "shuffle_check"
 powell.F: Found GOTO statement in procedure "newuob"
 preconditioner_makes.F: Found WRITE statement with hardcoded unit in "make_full_all"
 preconditioner_makes.F: Found WRITE statement with hardcoded unit in "make_full_all_ortho"
@@ -196,7 +197,6 @@ se_core_matrix.F: Found WRITE statement with hardcoded unit in "makeds"
 se_core_matrix.F: Found WRITE statement with hardcoded unit in "makes"
 se_fock_matrix_coulomb.F: Found WRITE statement with hardcoded unit in "build_fock_matrix_coulomb_lr"
 se_fock_matrix_dbg.F: Found WRITE statement with hardcoded unit in "dbg_energy_coulomb_lr"
-semi_empirical_int3_utils.F: Routine EVAL called with an implicit interface.
 semi_empirical_int_debug.F: Found WRITE statement with hardcoded unit in "check_dcore_nucint_ana"
 semi_empirical_int_debug.F: Found WRITE statement with hardcoded unit in "check_dcorecore_ana"
 semi_empirical_int_debug.F: Found WRITE statement with hardcoded unit in "check_drotnuc_ana"
@@ -207,7 +207,6 @@ semi_empirical_int_debug.F: Found WRITE statement with hardcoded unit in "check_
 semi_empirical_int_debug.F: Found WRITE statement with hardcoded unit in "check_value"
 semi_empirical_int_debug.F: Found WRITE statement with hardcoded unit in "rot_2el_2c_first_debug"
 semi_empirical_int_debug.F: Routine CHECK_VALUE called with an implicit interface.
-semi_empirical_int_utils.F: Routine EVAL called with an implicit interface.
 semi_empirical_mpole_methods.F: Found WRITE statement with hardcoded unit in "semi_empirical_mpole_p_setup"
 spherical_harmonics.F: Found WRITE statement with hardcoded unit in "cgc"
 spherical_harmonics.F: Found WRITE statement with hardcoded unit in "get_factor"