Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long-range quantum computing (WF) in short-range DFT embedding #2924

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

stefabat
Copy link
Contributor

This PR revamps the active space module and implements an embedding approach based on range-separated DFT.

An active space Hamiltonian describing a few electrons in a few orbitals embedded in the field of all remaining electrons is solved iteratively with external software.
The current implementation is interfaced to qiskit-nature, which enables the solution of the active space problem on classical and quantum hardware alike.

@stefabat stefabat changed the title WIP: long-range quantum computing (WF) in short-range DFT embedding Long-range quantum computing (WF) in short-range DFT embedding Aug 24, 2023
@juerghutter juerghutter merged commit cd366a4 into cp2k:master Aug 24, 2023
34 checks passed
@oschuett
Copy link
Member

It would be great to have an integration test for qiskit-nature. Maybe you could draft something akin to test_i-pi.sh or share an example input?

@fstein93
Copy link
Contributor

This PR introduced a compilation issue. The moduel hdf5_wrapper has to check for __HDF5 (check cp2k_info for reference) and wrap the respective use statements and function bodies to prevent compilation errors if CP2K is not compiled with HDF5.

@stefabat
Copy link
Contributor Author

It would be great to have an integration test for qiskit-nature. Maybe you could draft something akin to test_i-pi.sh or share an example input?

Yes, I can do that. I have another repo with many test examples and I can easily pull one or a few of them out.

@stefabat
Copy link
Contributor Author

This PR introduced a compilation issue. The moduel hdf5_wrapper has to check for __HDF5 (check cp2k_info for reference) and wrap the respective use statements and function bodies to prevent compilation errors if CP2K is not compiled with HDF5.

You are right, I somehow completely forgot about hdf5_wrapper

@stefabat
Copy link
Contributor Author

It would be great to have an integration test for qiskit-nature. Maybe you could draft something akin to test_i-pi.sh or share an example input?

Yes, I can do that. I have another repo with many test examples and I can easily pull one or a few of them out.

Actually, I first have to discuss with @mrossinek on how to do this, so it might take a few days before we have something similar in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants