Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug with storing embedding info in metadata store #1101

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Conversation

sarahwooders
Copy link
Collaborator

Please describe the purpose of this pull request.
Previously the source.embedding_dim and source.embedding_model fields were always None because they were not being properly written during the load command. This resulted in errors during /attach which checks to make sure embedding models of the agent/source match.

How to test

  1. Load: memgpt load directory --name memgpt_docs7 --input-dir docs --recursive
  2. List sources memgpt list sources
  3. Run /attach on memgpt run

Have you tested this PR?
Yes

Copy link
Owner

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpacker cpacker merged commit 9280568 into main Mar 6, 2024
4 checks passed
@cpacker cpacker deleted the attach-bug branch March 6, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants