Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (1) refactor in Agent.step() to fix out-of-order timestamps, (2) bug fixes with usage of preset/human vs filename values #1145

Merged
merged 11 commits into from
Mar 17, 2024

Conversation

cpacker
Copy link
Owner

@cpacker cpacker commented Mar 12, 2024

  • refactor step() to fix out-of-order timestamps due to duplicate message
  • correct use of persona and human - in many instances we were using them as persona/human_name, even though the values were expected to be the full value
  • modify Preset model to contain a persona_name and human_name
  • pull these values in the REST API when returning information about the agents in the list_agents GET route

Many of the line diffs are to fix a tangentially related bug where human_name and persona_name aren't being used correctly. For a future PR, we should strip this field and replace it with human_id and persona_id that point to the DB.

- [ ] TODO: strip human/persona_name, and refer to ID in table instead

@cpacker cpacker changed the title fix: init refactor to try and squash timestamp bug fix: (1) refactor in Agent.step() to fix out-of-order timestamps, (2) bug fixes with usage of preset/human vs filename values Mar 16, 2024
@cpacker cpacker added the API Related to MemGPT API label Mar 16, 2024
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cpacker cpacker merged commit 6abe5c5 into main Mar 17, 2024
4 checks passed
@cpacker cpacker deleted the patch-outoforder-bug branch March 17, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to MemGPT API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants