fix: fix azure credential configuration #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`azure_deployment` not properly stored. Missing `azure_key` check is wrong.
cpacker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
Bug fix: Azure API cannot be properly set up.
Problems:
azure_versionexistence was checked twice,azure_apiexistence was not checked.azure_versionandazure_endpointare not saved during configuration.azure_deploymentnot saved if using a embedding provider different from azure.How to test
Follow the official MemGPT document on configuring Azure OpenAI API.
Before this patch, when running
memgpt configure:When running
memgpt run:Azure API calls will fail with HTTP error "unauthorized".
Have you tested this PR?
Yes.
Additional Message
https://github.com/cpacker/MemGPT/compare/main...xavieryao:MemGPT:azure_cred?expand=1#diff-ebba04859ec9cde65c68649dcd42eddc80428ca2d0de26d241bf0946210e6a30L630 seems to have no effect.