fix: duplicate passage across/within files causing issues in insert_many with postgres #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhil-pandey
changed the title
nikhil-pandey
changed the title
nikhil-pandey
changed the title
sarahwooders
approved these changes
Apr 1, 2024
sarahwooders
requested changes
Apr 1, 2024
cpacker
approved these changes
Apr 2, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
Bug Fix for #1197
How to test
Try to load two files that would chunk to same text. Both will produce the same embedding. Insert Many will fail because of constraint violation.
Have you tested this PR?
Yes
Related issues or PRs
Issue