-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clean up and simplify docker entrypoint #1235
fix: Clean up and simplify docker entrypoint #1235
Conversation
👀 😍 |
@cpacker are there sample |
|
6c5dbe1
to
726e890
Compare
So we've got most of the test suite passing in the container, can be run with
# config is not defined in this module or imported
llm_config=config.default_llm_config,
embedding_config=config.default_embedding_config,
I can keep at it, however this PR is getting large; I could alternatively exclude the problem tests when run in docker for the moment, and then chip away with smaller PRs to keep cleaning up? @cpacker let me know what makes the most sense |
@cpacker @norton120 maybe we can merge this into a separate branch from main, so I can help push it over the finish line wrt passing tests, formatting, etc.? This would be a great PR to get merged asap. |
SGTM, just changed the PR base to a new staging branch. |
@norton120 I left a comment on #1259 with a few questions! |
Please describe the purpose of this pull request.
Squaring away the compose implementation to make things a little more tidy.
nginx reverse-proxy
docker compose up -d && open http://memgpt.localhost
and open the local server.localhost:8083
andlocalhost:8283
still work, so since it seems like ports are hardcoded differently in different places we can be flexible.pgdata
docker volume to a locally mounted.pgdata
folder. If you are a dev with multiple containerized projects on your machine this is an easy collision to avoid.pydantic_settings
settings
singleton.memgpt_pg_uri
envar with the component envars - so you only set one.There is more of this to go, but this at least starts to establish the pattern and make it easier to abstract config logic for the server.
How to test
Workin' on this. contributors should be able to run the full test suite in the container. I for one put nothing on my metal, and containerized tests drop the barrier to entry.
Have you tested this PR?
Eyeballed, still working on running the test suite in containers.
Related issues or PRs
#1233
Is your PR over 500 lines of code?
This is a lot of dry'ing and cleanup, so it will ideally reduce the codebase by more than 500 lines.