fix: allow passing full postgres URI and only override config URI is env variables provided #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
cpacker
approved these changes
May 3, 2024
neverbiasu
pushed a commit
to neverbiasu/MemGPT
that referenced
this pull request
May 6, 2024
…env variables provided (cpacker#1327) Co-authored-by: cpacker <packercharles@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
We should eventually migrate to more cleanly directly using environment variables if provided, and defaulting to the config file otherwise, but these are some short-term fixes:
Related issues or PRs
#1319
Is your PR over 500 lines of code?
No