Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more cli functions migrated to run on top of client #1462

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

KrishnaM251
Copy link
Contributor

@KrishnaM251 KrishnaM251 commented Jun 19, 2024

Please describe the purpose of this pull request.
Feature

How to test
poetry run pytest -s tests/test_local_client_cli.py
poetry run pytest -s tests/test_rest_client_cli.py

Have you tested this PR?
Yes, each new testing file has 4 tests that all pass AFTER memgpt configure has been run.

Related issues or PRs
#1386

Is your PR over 500 lines of code?
Yes, but I believe @sarahwooders is ok with this.

Additional Context

  • I only tested with chroma for archival data and sqlite for recall data
  • To the best of my knowledge, I have migrated everything except:
    • megmpt migrate (I did not touch this)
    • memgpt run (~90% implemented, no test)
      • current bug lies with running “/attach”
      • However, (I believe) all other memgpt run functionalities are working under both a RESTClient or a LocalClient
  • Regarding everything else: my tests pass but they override the user’s config
    • just need to find a way to save the user’s configs and credentials at the start of the test, and then reset them accordingly at the end
  • If you want to revert my progress on memgpt load, search across the project for “# krishna” or just remove my changes in:
    • cli.py
      • run(), create_default_user_or_exit(), make_default_user_or_exit(),
    • main.py
      • run_agent_loop()

Checklist

  • Add/List/Delete LocalClient
    • Agents
    • Humans
    • Personas
    • Sources
    • Presets
  • Add/List/Delete RESTClient
    • Agents
    • Humans
    • Personas
    • Sources
    • Presets
  • Others
    • Run
    • Load
    • Migrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To triage
Development

Successfully merging this pull request may close these issues.

None yet

1 participant