Skip to content

Commit

Permalink
net/enic: avoid error message when no advanced filtering
Browse files Browse the repository at this point in the history
[ upstream commit af397b3 ]

Probing the availability of Flow Manager API may print the following
error log.

PMD: rte_enic_pmd: Devcmd 88 failed with error code -1

The error indicates a flow manager operation failed and happens when
advanced filtering is disabled on vNIC. It is harmless but confusing
to the user. Since advanced filtering is a prerequisite, check first
if it is available and avoid the error message altogether.

Fixes: ea7768b ("net/enic: add flow implementation based on Flow Manager API")

Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
Reviewed-by: John Daley <johndale@cisco.com>
  • Loading branch information
Hyong Youb Kim authored and cpaelzer committed Nov 30, 2021
1 parent 710a081 commit 0dfb8b4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/enic/base/vnic_dev.c
Expand Up @@ -520,6 +520,9 @@ static int vnic_dev_flowman_enable(struct vnic_dev *vdev, u32 *mode,
u64 ops;
static u32 instance;

/* Advanced filtering is a prerequisite */
if (!vnic_dev_capable_adv_filters(vdev))
return 0;
/* flowman devcmd available? */
if (!vnic_dev_capable(vdev, CMD_FLOW_MANAGER_OP))
return 0;
Expand Down

0 comments on commit 0dfb8b4

Please sign in to comment.