Skip to content

Commit

Permalink
net/af_xdp: add missing trailing newline in logs
Browse files Browse the repository at this point in the history
[ upstream commit 744fd4126937b7f195fac38ae24cab52d0922b04 ]

Caught while trying --in-memory mode, some log messages in this driver
are not terminated with a newline:
rte_pmd_af_xdp_probe(): net_af_xdp: Failed to register multi-process IPC
callback: Operation not supportedvdev_probe(): failed to initialize
net_af_xdp device

Other locations in this driver had the same issue, fix all at once.

Fixes: f1debd7 ("net/af_xdp: introduce AF_XDP PMD")
Fixes: d8a2107 ("net/af_xdp: support unaligned umem chunks")
Fixes: 9876cf8316b3 ("net/af_xdp: re-enable secondary process support")

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ciara Loftus <ciara.loftus@intel.com>
  • Loading branch information
david-marchand authored and cpaelzer committed Mar 9, 2022
1 parent 1e68fe3 commit 1716c2f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/af_xdp/rte_eth_af_xdp.c
Expand Up @@ -783,7 +783,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals __rte_unused,

umem = rte_zmalloc_socket("umem", sizeof(*umem), 0, rte_socket_id());
if (umem == NULL) {
AF_XDP_LOG(ERR, "Failed to allocate umem info");
AF_XDP_LOG(ERR, "Failed to allocate umem info\n");
return NULL;
}

Expand All @@ -795,7 +795,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals __rte_unused,
&umem->fq, &umem->cq, &usr_config);

if (ret) {
AF_XDP_LOG(ERR, "Failed to create umem");
AF_XDP_LOG(ERR, "Failed to create umem\n");
goto err;
}
umem->buffer = base_addr;
Expand All @@ -819,7 +819,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,

umem = rte_zmalloc_socket("umem", sizeof(*umem), 0, rte_socket_id());
if (umem == NULL) {
AF_XDP_LOG(ERR, "Failed to allocate umem info");
AF_XDP_LOG(ERR, "Failed to allocate umem info\n");
return NULL;
}

Expand Down Expand Up @@ -855,7 +855,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
&usr_config);

if (ret) {
AF_XDP_LOG(ERR, "Failed to create umem");
AF_XDP_LOG(ERR, "Failed to create umem\n");
goto err;
}
umem->mz = mz;
Expand Down

0 comments on commit 1716c2f

Please sign in to comment.