Skip to content

Commit

Permalink
test/power: fix CPU frequency when turbo enabled
Browse files Browse the repository at this point in the history
[ upstream commit 29343b9 ]

On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not
be exactly the same as what was set when using CPPC cpufreq driver.
For other cpufreq driver, no need to round it currently, or else
this check will fail with turbo enabled. For example, with acpi_cpufreq,
cpuinfo_cur_freq can be 2401000 which is equal to freqs[0].It should
not be rounded to 2400000.

Fixes: 606a234 ("test/power: round CPU frequency to check")

Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
Acked-by: David Hunt <david.hunt@intel.com>
  • Loading branch information
richael02 authored and cpaelzer committed Aug 9, 2021
1 parent 6918066 commit 4da3e8a
Showing 1 changed file with 14 additions and 9 deletions.
23 changes: 14 additions & 9 deletions app/test/test_power_cpufreq.c
Expand Up @@ -55,7 +55,9 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo)
FILE *f;
char fullpath[PATH_MAX];
char buf[BUFSIZ];
enum power_management_env env;
uint32_t cur_freq;
uint32_t freq_conv;
int ret = -1;
int i;

Expand All @@ -80,15 +82,18 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo)
goto fail_all;

cur_freq = strtoul(buf, NULL, TEST_POWER_CONVERT_TO_DECIMAL);

/* convert the frequency to nearest 100000 value
* Ex: if cur_freq=1396789 then freq_conv=1400000
* Ex: if cur_freq=800030 then freq_conv=800000
*/
unsigned int freq_conv = 0;
freq_conv = (cur_freq + TEST_FREQ_ROUNDING_DELTA)
/ TEST_ROUND_FREQ_TO_N_100000;
freq_conv = freq_conv * TEST_ROUND_FREQ_TO_N_100000;
freq_conv = cur_freq;

env = rte_power_get_env();
if (env == PM_ENV_CPPC_CPUFREQ) {
/* convert the frequency to nearest 100000 value
* Ex: if cur_freq=1396789 then freq_conv=1400000
* Ex: if cur_freq=800030 then freq_conv=800000
*/
freq_conv = (cur_freq + TEST_FREQ_ROUNDING_DELTA)
/ TEST_ROUND_FREQ_TO_N_100000;
freq_conv = freq_conv * TEST_ROUND_FREQ_TO_N_100000;
}

if (turbo)
ret = (freqs[idx] <= freq_conv ? 0 : -1);
Expand Down

0 comments on commit 4da3e8a

Please sign in to comment.