Skip to content

Commit

Permalink
net/bnxt: fix xstats query
Browse files Browse the repository at this point in the history
[ upstream commit c05c22f9b8032c2974de7042ba8c38fb42ed7c82 ]

Fix incorrect memset in bnxt_dev_xstats_get_op.
In bnxt_dev_xstats_get_op(), the PMD is not zeroing the whole
buffer supplied by the application. This can end up passing
junk statistics values to the application when the FW does not
support extended stats on a function.
Fixed to call memset() with correct size.

Fixes: f55e12f ("net/bnxt: support extended port counters")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
  • Loading branch information
Kalesh AP authored and cpaelzer committed Feb 25, 2022
1 parent 21d32d5 commit 5b11370
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/bnxt/bnxt_stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
(bp->fw_tx_port_stats_ext_size /
stat_size));

memset(xstats, 0, sizeof(*xstats));
memset(xstats, 0, sizeof(*xstats) * n);

count = 0;
for (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) {
Expand Down

0 comments on commit 5b11370

Please sign in to comment.